Skip to content

Commit 35df93c

Browse files
committed
Don't use newlines with $self->error() as these also go to syslog
1 parent 44bfdea commit 35df93c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

ncm-spma/src/main/perl/spma-run

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -321,23 +321,23 @@ sub get_cmdfile
321321
}
322322

323323
if (length($cmdfile) == 0 or ! -e $cmdfile) {
324-
$self->error("command file '$cmdfile' is missing\n" .
325-
" run 'ncm-ncd -configure spma' to create it");
324+
$self->error("command file '$cmdfile' is missing, " .
325+
"run 'ncm-ncd -configure spma' to create it");
326326
$self->finish(-1);
327327
}
328328

329329
#
330330
# Security checks
331331
#
332332
if (! -o $cmdfile) {
333-
$self->error("command file '$cmdfile' has wrong owner\n" .
334-
" must be owned by root user");
333+
$self->error("command file '$cmdfile' has wrong owner, " .
334+
"must be owned by root user");
335335
$self->finish(-1);
336336
}
337337
my $mode = (stat($cmdfile))[2];
338338
if (($mode & S_IWGRP) or ($mode & S_IWOTH)) {
339-
$self->error("command file '$cmdfile' too permissive\n" .
340-
" should be writable by root only");
339+
$self->error("command file '$cmdfile' too permissive, " .
340+
"should be writable by root only");
341341
$self->finish(-1);
342342
}
343343

0 commit comments

Comments
 (0)