Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvuln: implement DeltaUpdateVulnerabilities for jsonblob store #1345

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

crozzy
Copy link
Contributor

@crozzy crozzy commented May 21, 2024

This change ensures that any updaters that implement the delta update flow also have their vulnerabilities persisted in the jsonblob store.

@crozzy crozzy requested a review from a team as a code owner May 21, 2024 19:01
@crozzy crozzy requested review from hdonnay and removed request for a team May 21, 2024 19:01
@crozzy crozzy mentioned this pull request May 21, 2024
10 tasks
Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense to me -- the alternative would be returning errors.ErrUnsupported and making lots of changes to the update manager.

This change ensures that any updater that implement the delta update
flow also have their vulnerabilities persisted in the jsonblob store.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.29%. Comparing base (94e3ee6) to head (50f9052).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
+ Coverage   56.25%   56.29%   +0.04%     
==========================================
  Files         266      266              
  Lines       16812    16812              
==========================================
+ Hits         9458     9465       +7     
+ Misses       6391     6385       -6     
+ Partials      963      962       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crozzy
Copy link
Contributor Author

crozzy commented Jun 14, 2024

/fast-forward

@github-actions github-actions bot merged commit 50f9052 into quay:main Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants