Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/copy rules #124

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Feature/copy rules #124

merged 6 commits into from
Mar 2, 2023

Conversation

dobestler
Copy link
Contributor

#78

Rule Management items can be copied/cloned to another rules collection.

@pbartusch
Copy link
Collaborator

Hi, thanks @dobestler so much for this contribution, and the use case context you provided on our call.

The main development of SMUI is also moving towards consolidation of deployment & authentication integration and their interplay. "Single preview" or "draft rule publishes" become a greater need for search managers as the topic evolves.

Though the topic IMHO is complex, and should not be underestimated. I therefore outlined a first approach, starting with the requirements: #127.

Context for this PR:

  • I understand, you want to use the copy feature with a separate rules collection, to provide a solution for draft rules.
  • Though, I am not sure, if (1) that'll meet the search manager's expectations, and (2) will fulfill all the listed requirements. I prefer to connect from there, and - if possible - also bring in the perspective of SMs.

The copy feature might otherwise be useful in other use case contexts, and still worth merging & maintaining. Though, as long as there is no use case to be named, and there is uncertainty around the way forward for SMUI with drafts / single publishes, I suggest to prioritize the clarification of those questions.

@mkr
Copy link
Collaborator

mkr commented Mar 1, 2023

I think @iris-stern (who originally opened #78) and @renekrie had some more use cases in mind.

@dobestler dobestler merged commit 597d3cf into master Mar 2, 2023
@pbartusch
Copy link
Collaborator

Thanks @mkr for highlighting this connection. I would like to understand this a little more in detail in #78 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants