Align with new intovalue reporting follow-up variables and update content #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
delwen
commented
Feb 22, 2022
delwen
commented
- Align with update to intovalue dataset (Added new follow-up time variables and removed city duplicates maia-sh/intovalue-data#25) with separate follow-up variables for reporting as summary results (based on the registry download date) and for reporting as a journal publication (based on the manual publication search)
- TODO: @bgcarlisle the new follow-up variable for summary results reporting led to us also having trials completed in 2016 for the summary results route. This leads to a mismatch between the pink descriptor text and the last completion year on the x axis in the 5-yr reporting plot (both in the Start and One UMC pages). I held off on changing that but we can consider adapting such that the pink descriptor text is based on latest available completion date. What do you think?
- Only show "publication only" and "summary results only" for the 2- and 5-year reporting plots (decision made on 22/02/2022 based on different follow-up times and hence denominators for reporting as summary results and as journal publication)
- Changed "linkage" to "publication links" (resolves Change linkage to links #50)
- Updates to the FAQ, methods and tooltips, including updated query dates
- Aligns with updates to follow-up variables (follow-up for journal publication is based on the manual search date, whereas follow-up for summary results reporting is based on the registry query date, see 5d7105695baf681f573a85f952dc31fc9df0b68e in intovalue-data repo)
- Addresses #50
- Decision on 22/02/2022 to only keep "publication only" and "summary results only" toggles for the 2- and 5-yr reporting plots as different denominators
- Updated query/download dates - Minor edits
Closed
bgcarlisle
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.