Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent new type of Luck.Main.parse breaks the template examples #4

Closed
pirapira opened this issue Mar 31, 2017 · 5 comments
Closed

Recent new type of Luck.Main.parse breaks the template examples #4

pirapira opened this issue Mar 31, 2017 · 5 comments

Comments

@pirapira
Copy link

A recent change 84d8bd3 seems to have broken the build of combinations.hs example in examples-tempalte directory.

Before the change:

[12:41] yh@sri: ~/infra-src/Luck/luck(:c64d06e|…)$ stack build && stack runghc examples-template/combination.hs
There were multiple candidates for the Cabal entry "Outer.Parser" (/home/yh/infra-src/Luck/luck/src/Outer/Parser.y), picking /home/yh/infra-src/Luck/luck/src/Outer/Parser.hs
Just [1,0,0,0,0,0,0,0,0,0,1,1,0]
Just [1,0,0,0,0,0,0,0,1,1,0,0,0]
Just [0,0,1,0,0,1,0,0,0,1,0,0,0]
Just [0,0,0,0,1,0,1,1,0,0,0,0,0]
Just [1,0,0,0,0,0,0,0,0,0,1,1,0]
Just [0,0,1,1,0,0,0,0,0,0,0,0,1]
Just [0,0,0,0,0,1,0,1,1,0,0,0,0]
Just [0,0,0,0,0,1,1,0,0,0,0,1,0]
Just [0,0,1,0,0,0,0,0,0,0,0,1,1]
Just [0,1,0,0,1,0,0,0,0,1,0,0,0]
Just [1,0,0,0,0,0,1,0,0,1,0,0,0]

After the change:

[12:44] yh@sri: ~/infra-src/Luck/luck(master|…)$ git show | head -n 1
commit 84d8bd30901b81ba57a3ec0696cd17e5b7d83e68
[12:45] yh@sri: ~/infra-src/Luck/luck(master|…)$ stack build && stack runghc examples-template/combination.hs
There were multiple candidates for the Cabal entry "Outer.Parser" (/home/yh/infra-src/Luck/luck/src/Outer/Parser.y), picking /home/yh/infra-src/Luck/luck/src/Outer/Parser.hs

examples-template/combination.hs:6:9: error:
    • Couldn't match type ‘Data.ByteString.Internal.ByteString’
                     with ‘[Outer.AST.Decl]’
      Expected type: Outer.AST.Prg
        Actual type: Data.ByteString.Internal.ByteString
    • In the second argument of ‘Luck.Main.parse’, namely
        ‘Data.ByteString.Char8.pack

I used GHC 8.0.1 for both experiments.

$ stack ghc -- --version
The Glorious Glasgow Haskell Compilation System, version 8.0.1
@Lysxia
Copy link
Collaborator

Lysxia commented Apr 7, 2017

Thanks for reporting this. This is now fixed upstream.

@pirapira
Copy link
Author

pirapira commented Apr 7, 2017 via email

@Lysxia
Copy link
Collaborator

Lysxia commented Apr 7, 2017

It's fine! I don't think we really have a designated place for issues, so this mirror might be as good as any other.

@Lysxia
Copy link
Collaborator

Lysxia commented Nov 5, 2017

Fixed since 2cb4727.

@Lysxia Lysxia closed this as completed Nov 5, 2017
@pirapira
Copy link
Author

pirapira commented Nov 9, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants