feat: Disable copy on write for disk images on btrfs #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lj3954
added a commit
to lj3954/quickemu-rs
that referenced
this pull request
May 21, 2024
Also, disable unsupported lazy_refcounts for non-qcow2 images
lj3954
requested changes
May 21, 2024
|
Sorry, my bad. It was a patch I was just carrying locally and decided to submit it. As to your comment, I also noticed lazy_refcounts cannot work with raw images, so decided to include a fix for that. Let me know if you would prefer that to be separated out into a new PR. |
lj3954
approved these changes
May 25, 2024
TheMuso
force-pushed
the
set-nocow-on
branch
2 times, most recently
from
4d35c71
to
a08e44e
Compare
According to qemu-img documentation, it is a no-op for other filesystems.
flexiondotorg
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to qemu-img documentation, it is a no-op for other filesystems.