Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user withdrawal records endpoint #1475

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

joe-bowman
Copy link
Contributor

@joe-bowman joe-bowman commented Apr 22, 2024

1. Summary

Fixes issue with all unbonding records showing post #1284 changes.

Summary by CodeRabbit

  • Documentation

    • Updated summaries and descriptions for various API endpoints to enhance clarity and usability.
  • New Features

    • Introduced a new API endpoint for querying user-specific withdrawal records.
  • Refactor

    • Updated URL patterns for several API endpoints to improve consistency and accessibility.

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quicksilver ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 1:57pm

Copy link
Contributor

coderabbitai bot commented Apr 22, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (2)
  • icq-relayer/go.mod is excluded by !**/*.mod
  • icq-relayer/go.sum is excluded by !**/*.sum

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update enhances the API documentation and RPC URL patterns for interchain staking, focusing on withdrawal records and mapped accounts. It introduces a new RPC for user-specific zone withdrawal records and revises existing endpoints with additional parameters and updated summaries.

Changes

File Path Changes Summary
docs/swagger.yml Updated summaries, parameters, and operation IDs for several endpoints.
proto/.../interchainstaking/v1/query.proto Added UserZoneWithdrawalRecords RPC; updated URL patterns for multiple RPCs.

🐰✨
In the land of code, under the moon's glow,
A rabbit hopped, with changes in tow.
New paths were laid, old ones refined,
In the dance of data, no string left behind. 🌟
🐾


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@joe-bowman
Copy link
Contributor Author

This pull request has been deployed to Vercel.

Latest commit: eacfc0d
✅ Preview: https://pr-1475.app-dev.quicksilver.zone
🔍 Inspect: https://vercel.com/quicksilver/quicksilver/5TCvBQFUHabNSLkoJ2mpXEvp2a4s

View Workflow Logs

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (77a6503) to head (eacfc0d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1475   +/-   ##
=======================================
  Coverage   63.58%   63.58%           
=======================================
  Files         171      171           
  Lines       11681    11681           
=======================================
  Hits         7427     7427           
  Misses       3504     3504           
  Partials      750      750           
Flag Coverage Δ
unittests 63.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@joe-bowman joe-bowman merged commit acd02ae into main Apr 22, 2024
26 checks passed
@joe-bowman joe-bowman deleted the fix-unbonding-endpoint branch April 22, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants