web ui/input validation #1510
web ui/input validation #1510
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate Limit Exceeded@chalabi2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 22 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates focus on refining the handling and calculation of token amounts within two components of a web UI. Changes include transitioning from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| let numericAmount = BigInt(Math.trunc(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6')))); | ||
|
|
||
| if (zone?.chainId === 'dydx-mainnet-1') { | ||
| smallestUnitAmount = numericAmount * Math.pow(10, 18); | ||
| } else { | ||
| smallestUnitAmount = numericAmount * Math.pow(10, 6); | ||
| if (numericAmount <= 0) { | ||
| numericAmount = BigInt(0); |
There was a problem hiding this comment.
Refactor to use more robust handling of token amount calculations.
The current implementation uses Math.trunc which could lead to precision issues with floating-point numbers. Consider using Math.floor or Math.ceil as appropriate to ensure more predictable behavior. Additionally, ensure that the multiplication by Math.pow(10, Number(zone?.decimals ?? '6')) is safe from floating-point precision errors.
- let numericAmount = BigInt(Math.trunc(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6'))));
+ let numericAmount = BigInt(Math.floor(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6'))));Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| let numericAmount = BigInt(Math.trunc(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6')))); | |
| if (zone?.chainId === 'dydx-mainnet-1') { | |
| smallestUnitAmount = numericAmount * Math.pow(10, 18); | |
| } else { | |
| smallestUnitAmount = numericAmount * Math.pow(10, 6); | |
| if (numericAmount <= 0) { | |
| numericAmount = BigInt(0); | |
| let numericAmount = BigInt(Math.floor(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6')))); | |
| if (numericAmount <= 0) { | |
| numericAmount = BigInt(0); |
| let numericAmount = BigInt(Math.trunc(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6')))); | ||
|
|
||
| if (numericAmount <= 0) { | ||
| numericAmount = BigInt(0); | ||
| } |
There was a problem hiding this comment.
Refactor to use more robust handling of token amount calculations.
The current implementation uses Math.trunc which could lead to precision issues with floating-point numbers. Consider using Math.floor or Math.ceil as appropriate to ensure more predictable behavior. Additionally, ensure that the multiplication by Math.pow(10, Number(zone?.decimals ?? '6')) is safe from floating-point precision errors.
- let numericAmount = BigInt(Math.trunc(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6'))));
+ let numericAmount = BigInt(Math.floor(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6'))));Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| let numericAmount = BigInt(Math.trunc(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6')))); | |
| if (numericAmount <= 0) { | |
| numericAmount = BigInt(0); | |
| } | |
| let numericAmount = BigInt(Math.floor(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6')))); | |
| if (numericAmount <= 0) { | |
| numericAmount = BigInt(0); | |
| } |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
=======================================
Coverage 62.97% 62.97%
=======================================
Files 192 192
Lines 13495 13495
=======================================
Hits 8499 8499
Misses 4181 4181
Partials 815 815
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This pull request has been deployed to Vercel.
|
1. Summary
Fixes # (issue)
When users tried staking a larger amount of dydx tokens the application errored and broke due to improper multiplication logic.
2.Type of change
Summary by CodeRabbit