fix(x/airdrop/keeper): hoist out sdk.Dec from constant strings

[odeke-em]

There is no need to unnecessarily recompute and recreate sdk.Dec values from the tier* constant values.

Fixes #1676

Summary by CodeRabbit

• Refactor
  • Improved code readability and maintainability by centralizing decimal value creation for different tiers.

[vercel]

@odeke-em is attempting to deploy a commit to the quicksilver Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

This change improves the code in the x/airdrop/keeper/claim_handler.go file by introducing new global variables for preset decimal values associated with different tiers. It replaces the previous method of creating these decimal values directly within function calls. This enhancement improves code readability and maintainability by centralizing the decimal value creation.

Changes

File	Summary of Changes
x/airdrop/keeper/claim_handler.go	Added global variables for decimal values corresponding to different tiers. They replace direct creation of decimal values within function calls.

Assessment against linked issues

Objective (Issue)	Addressed	Explanation
Hoist constant string values for sdk.Dec parsing (#1676)	✅

Poem

In lines of code where decimals sprawled,
A rabbit's hop and they were called,
From strings to globals, neat and lean,
The code now shines, a cleaner sheen.
With tiers of value, once scattered wide,
To central spots, they now reside.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 154b78d and 2f671de.

Files selected for processing (1)

• x/airdrop/keeper/claim_handler.go (3 hunks)

Files skipped from review due to trivial changes (1)

• x/airdrop/keeper/claim_handler.go

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.93%. Comparing base (154b78d) to head (2f671de).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1677   +/-   ##
=======================================
  Coverage   63.93%   63.93%           
=======================================
  Files         195      195           
  Lines       13757    13757           
=======================================
  Hits         8795     8795           
  Misses       4099     4099           
  Partials      863      863           

Flag	Coverage Δ
unittests	63.93% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
x/airdrop/keeper/claim_handler.go	60.69% <50.00%> (ø)

[tuantran1702]

Thanks @odeke-em for the improvement!