Catalog loaded bool

[pjrobertson]

I found this commit lying about in my branches (yes, somebody's been tidying up!)
83fab29f70117f70d226ce8b3b02d97b32ecf9ea

Not sure if it fixes a crash or something, but looks useful.
I also found a small optimisation commit somewhere, which didn't find its way into master, so it's here

[skurfer]

The plug-ins use QSLibrarian, so I'm worried about adding an iVar. I suppose adding it to the end is probably safe (vs. inserting it into the middle somewhere). Is that true?

[pjrobertson]

Plugins don't subclass, so there shouldn't be a need to worry.

So I can stop you worrying:
https://groups.google.com/forum/?fromgroups=#!searchin/quicksilver---development/64$20bit$20class/quicksilver---development/k8afy9oaSo4/Xk6GfiLO05IJ

:D

On 15 November 2012 14:34, Rob McBroom notifications@github.com wrote:

The plug-ins use QSLibrarian, so I'm worried about adding an iVar. I
suppose adding it to the end is probably safe (vs. inserting it into the
middle somewhere). Is that true?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1216#issuecomment-10410251.

[tiennou]

If you feel really concerned about 32bit compatibility, put it in a static BOOL var. QSLibrarian is supposed to be a singleton, right ? ;-)

[pjrobertson]

Hehe. You can tell that when I originally did this change (a year ago) I was concerned about 32bit compatibility (see the original commit here )
Now you can see I'm not ;-)

I'm happy to use a static as per 83fab29f70117f70d226ce8b3b02d97b32ecf9ea if it makes everyone happy.

[skurfer]

OK, I had forgotten it only affected subclasses. So this should be fine. I'll test it out.