treat current selection as a string when type is unknown #1311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the thinking was behind these defaults. The history credits it to the "Code cleanup" commit. :-(
Anyway, I see no reason to include the file type. The value for it is empty anyway, and in situations where the Current Selection proxy should have a file type, it does without this default (tested in Finder and Path Finder).
The reason for this change is that the "Find With…" action wouldn't appear for Current Selection. The Web Search plug-in only allows that action for objects with the text type, but no file type.
If anyone is uncomfortable with this change, there are at least two other ways to fix it in the plug-in instead:
validSingleFilePath
instead. So if it's just a blank dummy type, it won't prevent the action from appearing.