Small fixes

[pjrobertson]

A running pull request with any 'small' fixes.
It initially started to fix #1353, but I've added various other things over time

[skurfer]

"Save Command to File…" should only show folders the same way "Move To…" does. I can fix it, just not right now. Leaving this here as a reminder.

And maybe it should be say "to Folder". :-)

[pjrobertson]

I see what you did there ;-)

It was so easy I couldn't resist, and just incase we all forgot I thought
I'd do it now.

I used the home folder as the default folder. Seemed like a reasonable
option to me

On 31 January 2013 14:16, Rob McBroom notifications@github.com wrote:

"Save Command to File…" should only show folders the same way "Move To…"
does. I can fix it, just not right now. Leaving this here as a reminder.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1357#issuecomment-12944073.

[pjrobertson]

P.S. - I picked up a bug with this code. Something else to fix, I can do it but just not right now ;-)

If currentFolderPath is nil, [NSNull null] gets used instead, which throws an exception later on down the line:

2013-01-31 14:25:25.948 Quicksilver[27659:303] -[NSNull loadIcon]: unrecognized selector sent to instance 0x7fff7c331310
2013-01-31 14:25:25.951 Quicksilver[27659:303] (
    0   CoreFoundation                      0x00007fff9339c0a6 __exceptionPreprocess + 198
    1   libobjc.A.dylib                     0x00007fff931ca3f0 objc_exception_throw + 43
    2   CoreFoundation                      0x00007fff93430229 -[NSException raise] + 9
    3   ExceptionHandling                   0x00000001002b465b NSExceptionHandlerExceptionRaiser + 210
    4   libobjc.A.dylib                     0x00007fff931ca3f0 objc_exception_throw + 43
    5   CoreFoundation                      0x00007fff934326ea -[NSObject(NSObject) doesNotRecognizeSelector:] + 186
    6   CoreFoundation                      0x00007fff9338a5ce ___forwarding___ + 414
    7   CoreFoundation                      0x00007fff9338a3b8 _CF_forwarding_prep_0 + 232
    8   QSInterface                         0x0000000100247818 -[QSObjectView setObjectValue:] + 104
    9   QSInterface                         0x0000000100253c17 -[QSSearchObjectView selectObjectValue:] + 487
    10  QSInterface                         0x000000010022d9fd -[QSCollectingSearchObjectView selectObjectValue:] + 109

[pjrobertson]

OK, I've fixed that bug, but now I've found another:

• Select an action that selects nil in the 3rd pane by default (say the 'append to...' action or the search for... action if your search clipboard is empty)
• Leave the dObject as it is
• change the aObject to another object that uses the 3rd pane by short circuiting (␣)
• Note how the iObj isn't updated

Can't fix it right now

[skurfer]

The third pane for web searches isn't being "refreshed" as it should. As described on IRC, if you reinvoke the interface with a previous web search still showing, hitting ↩ runs the old search instead of going to text mode in the third pane. Also (probably the same bug), search text doesn't appear in the third pane. To reproduce:

1. Bring up a web search
2. Enter some text in the third pane
3. Dismiss QS (or do the search - doesn't matter)
4. Select some text in another application, then hit ⌘E
5. Invoke QS

The text from the Find pasteboard should appear in the third pane, but it doesn't unless you change the dObject to something other than a web search, then back again.

[pjrobertson]

hmm... I can't reproduce your 2nd problem, but if I reinvoke QS and press ↩ I see the 3rd pane isn't selected

[pjrobertson]

git bisect shows 03d921f is the culprit. Expected really as its an 'optimisation' - in inverted commas ;-)