Apply suggestions from code review

Co-authored-by: Adrien Guillo <adrien@quickwit.io>
quickwit-oss · Dec 6, 2023 · 46d61e7 · 46d61e7
1 parent 8e193aa
commit 46d61e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/quickwit/quickwit-cli/tests/cli.rs b/quickwit/quickwit-cli/tests/cli.rs
@@ -814,7 +814,7 @@ async fn test_garbage_collect_index_cli() {
     metastore
         .mark_splits_for_deletion(MarkSplitsForDeletionRequest::new(
             index_uid.clone(),
-            vec![split_metadata.clone().split_id.to_string()],
+            vec![split_metadata.split_id.to_string()],
         ))
         .await
         .unwrap();

diff --git a/quickwit/quickwit-metastore/src/metastore/file_backed_metastore/mod.rs b/quickwit/quickwit-metastore/src/metastore/file_backed_metastore/mod.rs
@@ -320,7 +320,7 @@ impl FileBackedMetastore {
     }
 
     /// Returns the list of splits for the given request.
-    /// No error is returned if one of the requested `index_uid` does not exist.
+    /// No error is returned if any of the requested `index_uid` does not exist.
     async fn inner_list_splits(&self, request: ListSplitsRequest) -> MetastoreResult<Vec<Split>> {
         let list_splits_query = request.deserialize_list_splits_query()?;
         let mut all_splits = Vec::new();
@@ -636,7 +636,7 @@ impl MetastoreService for FileBackedMetastore {
     /// Read-only accessors
 
     /// Streams of splits for the given request.
-    /// No error is returned if one of the requested `index_uid` does not exist.
+    /// No error is returned if any of the requested `index_uid` does not exist.
     async fn list_splits(
         &mut self,
         request: ListSplitsRequest,