Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lambda search endpoints using a warp adapter #4805

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Lambda search endpoints using a warp adapter #4805

merged 6 commits into from
Apr 3, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Mar 28, 2024

Description

Closes #4614

How was this PR tested?

Endpoint integration tests can be performed with:

# deploy the stack
export CDK_ACCOUNT=123456789
export CDK_REGION=us-east-1
export SEARCHER_API_KEY=my-at-least-20-char-long-key
export QW_LAMBDA_BUILD=1
make bootstrap
make deploy-mock-data
# ...wait a few minutes...
make test-mock-data-endpoints

@rdettai rdettai self-assigned this Mar 28, 2024
@rdettai rdettai linked an issue Mar 28, 2024 that may be closed by this pull request
Expose field capabitilies endpoint in the Lambda searcher #4614
Closed
@rdettai rdettai force-pushed the lambda-warp branch 2 times, most recently from d2381ae to 96fd9ca Compare March 28, 2024 15:41
@rdettai
Copy link
Contributor Author

rdettai commented Mar 28, 2024

started addressing #4734 by making default fmt logging more compact

trinity-1686a
trinity-1686a reviewed Mar 29, 2024
View reviewed changes
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is that PR configured to merge into lambda-prune-checkpoints?

So you ended up always keeping the static context instead of supporting generating a new SearchService for each request?

quickwit/quickwit-lambda/Cargo.toml Outdated Show resolved Hide resolved
quickwit/quickwit-lambda/src/searcher/warp_lambda.rs Outdated Show resolved Hide resolved
@rdettai rdettai mentioned this pull request Apr 2, 2024
Closed
Base automatically changed from lambda-prune-checkpoints to main April 3, 2024 08:11
@rdettai rdettai merged commit 24dc8d5 into main Apr 3, 2024
4 checks passed
@rdettai rdettai deleted the lambda-warp branch April 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trinity-1686a trinity-1686a trinity-1686a approved these changes

Assignees

@rdettai rdettai

Labels
aws-lambda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose field capabitilies endpoint in the Lambda searcher
2 participants
@rdettai @trinity-1686a