Remove unused crates from dependencies #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PSeitz can you review? |
PSeitz
reviewed
May 2, 2023
| @@ -7,7 +7,6 @@ license = "MIT" | |||
| [dependencies] | |||
| murmurhash32 = "0.3" | |||
| common = { version = "0.5", path = "../common/", package = "tantivy-common" } | |||
| criterion = "0.4.0" | |||
There was a problem hiding this comment.
this should be a dev dependency
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2018 +/- ##
==========================================
- Coverage 94.42% 94.42% -0.01%
==========================================
Files 319 319
Lines 59209 59216 +7
==========================================
+ Hits 55908 55914 +6
- Misses 3301 3302 +1
|
|
Thanks for the PR! |
PSeitz
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused crates from dependencies.