Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/route refactor #9

Merged
merged 6 commits into from
Jan 10, 2020
Merged

Feat/route refactor #9

merged 6 commits into from
Jan 10, 2020

Conversation

ThomasLee94
Copy link
Contributor

This PR will resolve the following:

  1. Refactor endpoints to provide OS information (i.e. /api/availableItems => /api/macos/availableItems)
  2. Update route docs accordingly.

vmarcella
vmarcella approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@vmarcella vmarcella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this for now, but the next api should be post fixed with v1 so that we can major version our APIs

@vmarcella vmarcella merged commit 7c59b2c into master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarcella vmarcella vmarcella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasLee94 @vmarcella