Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter doesn't handle STREAM frames with implicit length #7

Open
Matthias247 opened this issue Aug 11, 2021 · 1 comment · May be fixed by #8
Open

Converter doesn't handle STREAM frames with implicit length #7

Matthias247 opened this issue Aug 11, 2021 · 1 comment · May be fixed by #8

Comments

@Matthias247
Copy link

I noticed that when a STREAM frame is received which has no explicit length information (length is until end of packet) then no length field is logged in the stream event. Wireshark shows a length however, so the info might already be extracted somewhere?

Wireshark view:
image

Emitted event:

[
    "15",
    "transport",
    "packet_received",
    {
        "packet_type": "1RTT",
        "header": {
            "dcid": "6ef15ae8d7504312",
            "packet_number": "957",
            "packet_size": 1200,
            "payload_length": 1189
        },
        "frames": [
            {
                "frame_type": "ack",
                "ack_delay": "0",
                "acked_ranges": [
                    [
                        "16",
                        "21"
                    ]
                ]
            },
            {
                "frame_type": "stream",
                "stream_id": "0",
                "offset": "1097128",
                "fin": false
            }
        ]
    }
],
Matthias247 added a commit to Matthias247/pcap2qlog that referenced this issue Aug 11, 2021
The property `quic.stream.length` that the tool uses doesn't seem to be emitted
by wireshark for frames that carry no explicit length information (stream frame is
at the end of the packet). In that case the generated qlog will not have a length field.

To fix this, we calculate the length based on the data in the frame (which is correctly
emitted).

Fixes quiclog#7
@Matthias247 Matthias247 linked a pull request Aug 11, 2021 that will close this issue
@rmarx
Copy link
Member

rmarx commented Aug 12, 2021

Hello Matthias,

Thanks for identifying the issue and submitting a PR!

Could you by any chance share a pcap containing this behaviour so I can test it before putting it live on qvis? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants