Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receipt of STOP_SENDING on already-closed stream #2048

Closed
dtikhonov opened this issue Nov 23, 2018 · 2 comments · Fixed by #2050
Closed

Receipt of STOP_SENDING on already-closed stream #2048

dtikhonov opened this issue Nov 23, 2018 · 2 comments · Fixed by #2050
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@dtikhonov
Copy link
Member

As of today, the draft states the following:

Receiving a STOP_SENDING frame for a locally-initiated send stream that is “Ready” or non-existent MUST be treated as a connection error of type PROTOCOL_VIOLATION.

Due to packet loss, it is possible for a STOP_SENDING frame to arrive after the stream initiator closes the stream. In this case, it should not be an error.

@mikkelfj
Copy link
Contributor

There are many other reasons why this could happen, but I don't think this is a problem. A stream does not cease to exist just because it is closed. From memory that state chart should be ok. But since you raise this point, perhaps clarification is needed.

@dtikhonov
Copy link
Member Author

dtikhonov commented Nov 23, 2018

The term "non-existent" is only used once in the entire draft. I presumed it meant "not yet opened or already closed."

EDIT: I meant to type "not yet opened or already closed."

@martinthomson martinthomson added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels Nov 26, 2018
martinthomson added a commit that referenced this issue Nov 26, 2018
This is the only relevant condition.

Closes #2048.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants