Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can VN and Retry packets be coalesced? #2407

Closed
marten-seemann opened this issue Feb 4, 2019 · 6 comments · Fixed by #2989
Closed

Can VN and Retry packets be coalesced? #2407

marten-seemann opened this issue Feb 4, 2019 · 6 comments · Fixed by #2989
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@marten-seemann
Copy link
Contributor

They don't have a length field, so the only place they could go is at the end of a packet.
As the spec currently stands, it's valid to send a packet like this.

There's little value in doing that. Do we want to continue to allow this?

@kazuho
Copy link
Member

kazuho commented Feb 4, 2019

My understanding is that they are implicitly forbidden, because coalescing packets belonging to different connections are forbidden, and because there’s nothing to coalesce with when either of the two types of the packets is sent.

I am not sure if we need to be more clear on that, considering the fact we generally use MAY for the discarding rules for coalesced packets.

@ianswett
Copy link
Contributor

ianswett commented Feb 4, 2019

VN certainly causes a new connection based on discussions in Tokyo.

Retry does not cause a new connection(ie: same ClientHello).

Clarifying this seems wise if it's not already clear.

@kazuho
Copy link
Member

kazuho commented Feb 4, 2019

Retry does not cause a new connection(ie: same ClientHello).

Yes, however when a Retry packet is being sent, there's nothing a server can send along with.

Regarding if we need to clarify, while I do not think it's absolutely necessary, I can see that people might want to have it stated considering the fact that we do utilize corner case rules of coalesced packets (see #2402).

@mnot
Copy link
Member

mnot commented Feb 19, 2019

So, is this editorial?

@janaiyengar
Copy link
Contributor

I'm with @kazuho, but I'm still wondering: what is the clarification that we can provide?

@kazuho
Copy link
Member

kazuho commented Feb 22, 2019

@janaiyengar Simply clarifying that "VN and Retry packets will never be coalesced" as part of the changes we would make in #2308 might be a good idea.

We do not need to use a RFC 2119 word here due to the editorial nature of the issue.

@mnot mnot added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Mar 13, 2019
martinthomson added a commit that referenced this issue Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants