Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove size optimization for Initial packets #2522

Closed
martinthomson opened this issue Mar 15, 2019 · 1 comment · Fixed by #2523
Closed

Remove size optimization for Initial packets #2522

martinthomson opened this issue Mar 15, 2019 · 1 comment · Fixed by #2523
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@martinthomson
Copy link
Member

Initial packets need to be in 1200 byte datagrams for DoS amplification reasons. We have an exception for the case where an ACK for a Handshake packet has been received from the peer. In that case, we remove the requirement to pad.

That condition is extraordinarily obscure, especially if we are suggesting that endpoints not send any more Initial packets once they have Handshake keys. Removing this text is the right answer.
@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -transport and removed design An issue that affects the design of the protocol; resolution requires consensus. labels Mar 15, 2019
martinthomson added a commit that referenced this issue Mar 15, 2019
@martinthomson
Remove exception for Initial padding
166dc58 
Builds on #2520.

Closes #2522.
@martinthomson martinthomson mentioned this issue Mar 15, 2019
Merged
@janaiyengar
Copy link
Contributor

+1 to the proposed resolution.

@mnot mnot added the design An issue that affects the design of the protocol; resolution requires consensus. label Apr 9, 2019
@martinthomson martinthomson added the proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. label Apr 9, 2019
@mnot mnot added design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. and removed design An issue that affects the design of the protocol; resolution requires consensus. proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. labels Apr 23, 2019
@kazuho kazuho mentioned this issue Nov 18, 2019
Closed
@erickinnear erickinnear mentioned this issue Jan 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove exception for Initial padding quicwg/base-drafts
3 participants
@martinthomson @mnot @janaiyengar