-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is CONNECTION_CLOSE ACK-eliciting? #3097
Comments
That also ensures the congestion controller never inadvertently blocks sending a CONNECTION_CLOSE, which is consistent with the intent. If we make this change, I believe APPLICATION_CLOSE needs to be on the list as well. Now that we discuss ack-eliciting in transport, I think we'd need to change both transport and recovery and mark this design. So I think this would be a slight improvement, but I an also imagine people claiming that CONNECITON_CLOSE is already special, so there's no need for a change. |
APPLICATION_CLOSE is no more. This seems like a fine change. |
This seems sensible. |
Discussed in Cupertino. Obvious correction. |
Somehow, I continue to forget this (see #3097), so the table has been wrong since the special annotations were added.
At the moment, we state that a QUIC packet that contains frames other than ACK and PADDING (section 1.2), but I wonder if that is true for CONNECTION_CLOSE frame.
A CONNECTION_CLOSE frame never elicits an acknowledgment. IIUC, it is not meant to be governed by the congestion controller.
Considering the aspects, I think we should add CONNECTION_CLOSE to the list of *non-*ACK-eliciting frames.
The text was updated successfully, but these errors were encountered: