-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QPACK Appendix B: nameIndex #3544
Comments
Yikes, that original name was a little hard to follow. It strikes me that this code could be improved by consistently choosing either Idx or Index throughout. Though that might require some additional attention to line length if the longer (and better) option is chosen. |
Broader question: do we still feel like the pseudocode is useful in general? |
Let's suppose that The next question is how The return value ( Can |
The code comes from a time when the index space was unified, and the first staticTable.size indexes were static and the rest were dynamic. And yes, getNameIndex can return "not found". I'll add some comments explaining this case and sanitize the pseudocode. |
* Use the current terminology (insert count, base, encoder stream) * Update to current design (modulo encoding of RIC) * Normalize naming: index vs. idx * Comments Fixes #3544
* [qpack] Overhaul the pseudocode * Use the current terminology (insert count, base, encoder stream) * Update to current design (modulo encoding of RIC) * Normalize naming: index vs. idx * Comments Fixes #3544 * Fix lint * Martin's feedback
It seems to me that
nameIndex
appears suddenly in Appendix B. What's that? Is it the same asnameIdx
?The text was updated successfully, but these errors were encountered: