Minor editorial fixes. #1656
Merged
Minor editorial fixes. #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
approved these changes
Aug 13, 2018
| @@ -261,7 +261,7 @@ immediately. A stream becomes unblocked when the greatest absolute index in the | |||
| dynamic table becomes greater than or equal to the Largest Reference for all | |||
| header blocks the decoder has started reading from the stream. If a decoder | |||
| encounters a header block where the actual largest reference is not equal to the | |||
| largest reference declared in the prefix, it MAY treat this as a stream error of | |||
| Largest Reference declared in the prefix, it MAY treat this as a stream error of | |||
There was a problem hiding this comment.
I could go either way on this one.... I tend to view it similarly to when -transport capitalizes "[Cc]onnection ID" -- "Largest Reference" is the field itself, while "the largest reference" means the greatest index referenced by the frame.
martinthomson
added
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"indexes" occurs once while "indices" occurs six times, reconcile. Small grammar fixes. Position vertical arrow to center of block. Update figure captions (Post-Base Index only applies to Request Streams). Capitalize "Largest Reference" as it is done dozens of places elsewhere. Fix obsolete reference to "frames" on control streams.