No octets #1921
Closed
No octets #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
the
editorial
mikkelfj
reviewed
Oct 26, 2018
| QUIC's congestion control is based on TCP NewReno {{?RFC6582}}. NewReno is | ||
| a congestion window based congestion control. QUIC specifies the congestion | ||
| QUIC's congestion control is based on TCP NewReno {{?RFC6582}}. NewReno is a | ||
| congestion window based congestion control. QUIC specifies the congestion |
There was a problem hiding this comment.
congestion control algorithm?
mikkelfj
reviewed
Oct 26, 2018
draft-ietf-quic-recovery.md
Outdated
| @@ -965,8 +964,8 @@ losses or increases in the ECN-CE counter. | |||
| ## Tail Loss Probe | |||
|
|
|||
| A TLP packet MUST NOT be blocked by the sender's congestion controller. The | |||
| sender MUST however count these bytes as additional bytes-in-flight, since a TLP | |||
| adds network load without establishing packet loss. | |||
| sender MUST however count TLP packets against bytes-in-flight, since a TLP adds | |||
There was a problem hiding this comment.
inconsistent use of bytes-in-flight vs bytes_in_flight - technically one might be for text the other for pseudo code.
There was a problem hiding this comment.
Good point, how about we remove the - here, because it's spelled "bytes in flight" everywhere else.
ianswett
approved these changes
Oct 26, 2018
draft-ietf-quic-recovery.md
Outdated
| @@ -965,8 +964,8 @@ losses or increases in the ECN-CE counter. | |||
| ## Tail Loss Probe | |||
|
|
|||
| A TLP packet MUST NOT be blocked by the sender's congestion controller. The | |||
| sender MUST however count these bytes as additional bytes-in-flight, since a TLP | |||
| adds network load without establishing packet loss. | |||
| sender MUST however count TLP packets against bytes-in-flight, since a TLP adds | |||
There was a problem hiding this comment.
Good point, how about we remove the - here, because it's spelled "bytes in flight" everywhere else.
Co-Authored-By: martinthomson <martin.thomson@gmail.com>
martinthomson
commented
Oct 28, 2018
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will get rotty pretty quickly, but the changes are fairly easy to make mechanically for the most part.