Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QPACK wording fix: decoders dont receive resets #2014

Merged

Conversation

dtikhonov
Copy link
Member

No description provided.

@dtikhonov dtikhonov changed the title 201811161345 decoders dont receive resets QPACK wording fix: decoders dont receive resets Nov 16, 2018
Cancellations, because the encoder cannot have any dynamic table references.
dynamic table references. An endpoint that receives a stream reset before
the end of a stream generates a Stream Cancellation instruction on the
decoder stream. Similarly, a decoder that abandons reading of a stream needs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you need to change here as well? i.e. "a decoder that abandons" -> "an endpoint that abandons"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point -- I'll modify this part as well.

Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to @kazuho's amendment, LGTM.

@MikeBishop MikeBishop added editorial An issue that does not affect the design of the protocol; does not require consensus. -qpack labels Nov 19, 2018
@afrind
Copy link
Contributor

afrind commented Nov 27, 2018

Can you resolve the conflicts? Probably the whole section moved.

@afrind afrind merged commit a21a18a into quicwg:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants