Ack-eliciting, not inflight #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
design
ianswett
reviewed
Dec 12, 2018
draft-ietf-quic-recovery.md
Outdated
| @@ -792,7 +792,7 @@ Pseudocode for SetLossDetectionTimer follows: | |||
| SetLossDetectionTimer(): | |||
| // Don't arm timer if there are no ack-eliciting packets | |||
| // in flight. | |||
| if (bytes_in_flight == 0): | |||
| if (no ack-eliciting packets oustanding): | |||
There was a problem hiding this comment.
We never define what outstanding means, from what I can find, though we do use it in a few spots. In this case, I believe it should be "no ack-eliciting packets In-flight"?
There was a problem hiding this comment.
we use it below, which is why I used it here. I could change them both to "in flight" or leave them at outstanding
There was a problem hiding this comment.
I sent #2120 to remove existing uses of outstanding.
ianswett
added a commit
that referenced
this pull request
Dec 12, 2018
Issue noticed when reviewing PR #2117
ianswett
reviewed
Dec 17, 2018
draft-ietf-quic-recovery.md
Outdated
| @@ -792,7 +792,7 @@ Pseudocode for SetLossDetectionTimer follows: | |||
| SetLossDetectionTimer(): | |||
| // Don't arm timer if there are no ack-eliciting packets | |||
| // in flight. | |||
| if (bytes_in_flight == 0): | |||
| if (no ack-eliciting packets outstanding): | |||
There was a problem hiding this comment.
Suggested change
| if (no ack-eliciting packets outstanding): | |
| if (no ack-eliciting packets in flight): |
janaiyengar
force-pushed
the
close2093
branch
from
d5ddc52
to
7dfe461
Compare
ianswett
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2093