HTTP: make few minor stylistic improvements #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
reviewed
Dec 12, 2018
draft-ietf-quic-http.md
Outdated
| confusion as servers could not reliably identify which elements of the priority | ||
| tree could safely be discarded. Clients could potentially reference closed | ||
| in describing the relative priority of requests. This created | ||
| confusion as servers could not identify reliably which elements of the priority |
There was a problem hiding this comment.
I think this is placed correctly, and I feel like the change reads awkwardly.
draft-ietf-quic-http.md
Outdated
| tree could safely be discarded. Clients could potentially reference closed | ||
| in describing the relative priority of requests. This created | ||
| confusion as servers could not identify reliably which elements of the priority | ||
| tree could be safely discarded. Clients could potentially reference closed |
There was a problem hiding this comment.
I think you're right that this ought to move, but I think "could be discarded safely" reads better than either.
martinthomson
added
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.