Reorder some text around dynamic table size #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 12, 2018 15:32
This commits only moves paragraphs around in whole. Paragraphs are not edited, redacted, broken up or joined. In addition, a new section "Eviction" is added.
This commit breaks up and rejoints paragraphs and changes the order of sentences. No sentence is modified, redacted, omitted, or added.
martinthomson
approved these changes
Dec 13, 2018
martinthomson
added
editorial
|
I just swapped the Eviction section with the Maximum Table Size one. This makes sense because eviction talks about maximum table size (soon to be renamed table capacity or something similar), so it should come first, then Maximum Table Size talks about the limit on this value. When working on #2115 I made this change so I decided to factor out the swap of these sections into this PR which is already about reordering, to keep #2115 more narrowly focused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a purely editorial PR reordering text. The first commit reorders paragraphs and adds a section title, the second commit reorders sentences and moves around paragraph boundaries, the third commit is some clarification of text.
This PR does not at all address the issue I raised at #2115 (comment).