Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow control edits #2136

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Flow control edits #2136

merged 1 commit into from
Dec 13, 2018

Conversation

janaiyengar
Copy link
Contributor

Closes #2082.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Dec 13, 2018
martinthomson
martinthomson approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really address the concern raised in #2082 in the way that @ekr might have preferred, but it is quite clear and it captures the intent of the previous discussion(s). I'm OK with this if @ekr can live with it.

@janaiyengar
Copy link
Contributor Author

@martinthomson : This is text that @ekr proposed. I'll merge this, and if @ekr thinks more is warranted, happy to discuss.

@janaiyengar janaiyengar merged commit 605edec into master Dec 13, 2018
@janaiyengar janaiyengar deleted the close2082 branch December 13, 2018 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianswett ianswett ianswett approved these changes

@marten-seemann marten-seemann marten-seemann approved these changes

@martinthomson martinthomson martinthomson approved these changes

@ekr ekr Awaiting requested review from ekr

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janaiyengar @martinthomson @marten-seemann @ianswett