Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process ECN before forgetting newly acked packets #2142

Merged
merged 1 commit into from
Dec 18, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions draft-ietf-quic-recovery.md
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,10 @@ Pseudocode for OnAckReceived and UpdateRtt follow:
latest_rtt = now - sent_packets[ack.largest_acked].time
UpdateRtt(latest_rtt, ack.ack_delay)

// Process ECN information if present.
if (ACK frame contains ECN information):
ProcessECN(ack)

// Find all newly acked packets in this ACK frame
newly_acked_packets = DetermineNewlyAckedPackets(ack)
for acked_packet in newly_acked_packets:
Expand All @@ -744,10 +748,6 @@ Pseudocode for OnAckReceived and UpdateRtt follow:
DetectLostPackets(ack.acked_packet)
SetLossDetectionTimer()

// Process ECN information if present.
if (ACK frame contains ECN information):
ProcessECN(ack)


UpdateRtt(latest_rtt, ack_delay):
// min_rtt ignores ack delay.
Expand Down