Minor TLS draft editorial corrections #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not quite as sure of these, but I believe they match the intent better.
mikkelfj
reviewed
Feb 9, 2019
martinthomson
requested changes
Feb 11, 2019
martinthomson
added
editorial
Still some points of contention
Per @MikeBishop's advice We're still a little stuck on whether or not QUIC provides a TLS record abstraction. If we can't resolve soon, I'll just separate out that change.
I still disagree with the critique, but it is way less important than the rest of the PR. Perhaps someone can show me the error of my ways over some Czech beer.
|
Ahh, the sweet taste of surrender. Thanks Martin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not quite as sure of these, but I believe they match the intent better.