Mandate allowing peer to create enough unidirectional streams for HTTP and QPACK #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2019
afrind
approved these changes
May 31, 2019
LPardue
reviewed
May 31, 2019
kazuho
reviewed
Jun 3, 2019
MikeBishop
approved these changes
Jun 6, 2019
|
It's acceptable but not ideal. Didnt we just remove a mandatory TP in some unrelated change? |
|
Also rebased to fix conflict. |
…P and QPACK As per #2100 (comment) HTTP MUST allow enough uni streams credits for mandatory streams (control, QPACK encoder/decoder, other mandatory extensions) but is not required to grant additional credits if the peer wastes them.
|
That is an exceptionally long sentence. But I think the text is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2100 (comment) HTTP MUST allow enough uni streams credits for mandatory streams (control, QPACK encoder/decoder, other mandatory extensions) but is not required to grant additional credits if the peer wastes them.
This is the companion PR to #2529 updating the requirements in the HTTP draft, and together they fix #2100. I created a separate PR since it touches -http instead of -qpack, so it doesn't get blocked by the QPACK refactoring.