Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove misleading sentence about connection IDs after Retry #2832

Merged
merged 1 commit into from
Jun 26, 2019
Merged

remove misleading sentence about connection IDs after Retry #2832

merged 1 commit into from
Jun 26, 2019

Conversation

marten-seemann
Copy link
Contributor

Retry always changes the connection ID.

nibanks
nibanks reviewed Jun 23, 2019
View reviewed changes
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need the sentence that says receiving a Retry packet likely indicates all 0-RTT packets were lost.

@ianswett
Copy link
Contributor

@nibanks The paragraph 2 before this one says exactly that.

nibanks
nibanks approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... I missed that. Thanks for pointing it out @ianswett.

@martinthomson martinthomson merged commit 39eacb3 into quicwg:master Jun 26, 2019
@martinthomson martinthomson added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickinnear erickinnear erickinnear approved these changes

@nibanks nibanks nibanks approved these changes

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marten-seemann @ianswett @nibanks @erickinnear @martinthomson