Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCID in short headers #2991

Merged
merged 2 commits into from
Aug 27, 2019
Merged

DCID in short headers #2991

merged 2 commits into from
Aug 27, 2019

Conversation

martinthomson
Copy link
Member

Invariants text was unclear on where the Destination Connection ID field
was and how big it could be.

Closes #2335.

Invariants text was unclear on where the Destination Connection ID field
was and how big it could be.

Closes #2335.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -invariants labels Aug 26, 2019
Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One editorial suggestion, but LG

A QUIC packet with a short header includes a Destination Connection ID
immediately following the first byte. The short header does not include the
Connection ID Lengths, Source Connection ID, or Version fields. The length of
the Destination Connection ID is not constrained in packets with a short header.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the Destination Connection ID is not constrained in packets with a short header.
the Destination Connection ID is not specified or constrained in packets with a short header.

@martinthomson martinthomson merged commit 1cfe40c into master Aug 27, 2019
@martinthomson martinthomson deleted the unclarity-short branch August 28, 2019 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-invariants editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariants: Unclarity in short headers
5 participants