Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery Changelog #3018

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Recovery Changelog #3018

merged 4 commits into from
Sep 12, 2019

Conversation

ianswett
Copy link
Contributor

No description provided.


- PTO should always send an ack-eliciting packet (#2895)
- Unify the Handshake Timer with the PTO timer (#2648, #2658, #2886)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if #2916 gets merged)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG, added in anticipating of #2916 being merged.

Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait to see if 2916 lands, otherwise, LGTM

@martinthomson martinthomson merged commit 61fa094 into master Sep 12, 2019
@martinthomson martinthomson deleted the ianswett-recovery-changelog branch September 12, 2019 01:10
@martinthomson martinthomson added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants