Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibit PADDING in response to ACK #3104

Merged
merged 4 commits into from
Oct 22, 2019
Merged

Prohibit PADDING in response to ACK #3104

merged 4 commits into from
Oct 22, 2019

Conversation

martinduke
Copy link
Contributor

Fixing #3100

ianswett
ianswett reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial suggestions, including improving the existing text.

draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
nibanks
nibanks approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though all the "non-ACK-eliciting packets" is a bit of a mouth full.

martinthomson
martinthomson approved these changes Oct 22, 2019
View reviewed changes
draft-ietf-quic-transport.md Outdated
it sends an ACK frame.
one ACK-frame-only packet in response to receiving an ack-eliciting packet. An
endpoint MUST NOT send a non-ack-eliciting packet in response to a non-ack-
eliciting packet, even if there are packet gaps which precede the received
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: Though this hyphenation looks sane when presented this way, it won't be guaranteed to render nicely. It might appear as non-ack- eliciting (note the extra space). I think that you should remove the wrapping on the hyphen.

@martinthomson martinthomson merged commit 9650f85 into quicwg:master Oct 22, 2019
@martinduke martinduke deleted the mduke-ban-padding branch October 22, 2019 23:48
This was referenced Oct 23, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibanks nibanks nibanks approved these changes

@ianswett ianswett ianswett approved these changes

@martinthomson martinthomson martinthomson approved these changes

@janaiyengar janaiyengar Awaiting requested review from janaiyengar

Assignees
No one assigned
Labels
-transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinduke @martinthomson @ianswett @nibanks