Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packets on one path must not adjust values for a different path #3139

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

erickinnear
Copy link
Contributor

The intent here was that either (a) you only ever have a singe CC context and you reset it for each path, or (b) you have a CC context for each path, in which case each context is strongly tied to a path and you don't need to reset anything (except when it's been a while and the previous values may no longer be valid, etc.). We require that everyone does at least (a), while not preventing folks who want to do extra work for a potential performance gain from doing (b).

Packets can contribute to the CC/RTT estimation for the old path if it's still around and you're willing to maintain that state, which is why this (mistakenly) was a SHOULD.

Closes #2909.

@martinthomson martinthomson added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels Oct 23, 2019
@martinthomson
Copy link
Member

This looks good. I'm calling it editorial. However, it changes normative language, so I want an opinion on that from at least @ianswett or @janaiyengar before merging (other opinions are also highly valued).

@janaiyengar
Copy link
Contributor

+1 that we should require this behavior. We know that implementers will try out tricks here if they want to, and there's no enforcement to stop that from happening.

@erickinnear
Copy link
Contributor Author

I agree that this seems generally editorial, but either way I think this is ready to go?

@martinthomson martinthomson merged commit 89b53f0 into quicwg:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path Migration makes unjustified assumptions about a new path.
7 participants