token-based greasing / initial packet protection (downgradable variant) #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…@DavidSchinazi)" This reverts commit 2553793.
…bet. versions and salts is better than nothing
Co-Authored-By: Mike Bishop <mbishop@evequefou.be>
…d values has been confusing
Co-Authored-By: MikkelFJ <mikkelfj@gmail.com>
Co-Authored-By: MikkelFJ <mikkelfj@gmail.com>
Co-Authored-By: MikkelFJ <mikkelfj@gmail.com>
Co-Authored-By: MikkelFJ <mikkelfj@gmail.com>
…-alias-downgradable
|
OBE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be split views on if the greasing should be downgradable.
This PR is a variant of #3166 that allows downgrade.
The design rationale is that a downgrade attack by a middlebox should be detectable, though it reveals the payload of the Initial packet.
The diff between #3166 and this PR is available at https://github.com/kazuho/base-drafts/compare/kazuho/new-token-with-alias..kazuho/new-token-with-alias-downgradable.