-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recovery-unused-references #331
Conversation
These references are unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep the informative references.
@@ -59,12 +44,7 @@ normative: | |||
|
|||
informative: | |||
|
|||
RFC3782: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, but these are all relevant informative references, so I'd rather keep them. The intent is to reference them before the next version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which case you're supposed to mention them somewhere in the text (otherwise idnits will give you warnings).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, in that case, can you add a TODO in the congestion control section that needs to be written to ensure I mention them there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could even resolve the IDNits issue by mentioning them in the TODO. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was sort of my hope :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved these all down to the TODO section except TLP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining fixes now contained in pr #372
@ianswett fixed all of these. Though there appears to be a bug in kramdown-rfc2629 that causes the reference to RFC5827 to be munged. I'll open a bug for that, where I will recommend that we move that reference to text. |
FWIW, it's not even clear that kramdown-rfc2629 is at fault here. It's current behaviour is surprising, but I don't believe it necessary for references in figures to work. |
These references are unused.