Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recovery-unused-references #331

Closed
wants to merge 1 commit into from
Closed

recovery-unused-references #331

wants to merge 1 commit into from

Conversation

reschke
Copy link
Contributor

@reschke reschke commented Feb 22, 2017

These references are unused.

These references are unused.
Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep the informative references.

@@ -59,12 +44,7 @@ normative:

informative:

RFC3782:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, but these are all relevant informative references, so I'd rather keep them. The intent is to reference them before the next version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case you're supposed to mention them somewhere in the text (otherwise idnits will give you warnings).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, in that case, can you add a TODO in the congestion control section that needs to be written to ensure I mention them there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could even resolve the IDNits issue by mentioning them in the TODO. :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was sort of my hope :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved these all down to the TODO section except TLP.

Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining fixes now contained in pr #372

@martinthomson
Copy link
Member

@ianswett fixed all of these. Though there appears to be a bug in kramdown-rfc2629 that causes the reference to RFC5827 to be munged. I'll open a bug for that, where I will recommend that we move that reference to text.

@martinthomson
Copy link
Member

FWIW, it's not even clear that kramdown-rfc2629 is at fault here. It's current behaviour is surprising, but I don't believe it necessary for references in figures to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants