Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset PTO and loss detection timer when discarding keys #3415

Merged
merged 5 commits into from
Mar 5, 2020
Merged

Reset PTO and loss detection timer when discarding keys #3415

merged 5 commits into from
Mar 5, 2020

Conversation

ianswett
Copy link
Contributor

@ianswett ianswett commented Feb 4, 2020 •
edited
Loading

Fixes #3272

@ianswett
Reset PTO and loss detection timer when discarding keys
5108eb3 
Fixes #3272 

This doesn't add normative statements, but it could if people would like.
@larseggert larseggert mentioned this pull request Feb 7, 2020
Closed
@ianswett ianswett added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Feb 7, 2020
@ianswett
Copy link
Contributor Author

ianswett commented Feb 7, 2020

Pseudocode added, PTAL

@martinthomson martinthomson added -recovery design An issue that affects the design of the protocol; resolution requires consensus. and removed editorial An issue that does not affect the design of the protocol; does not require consensus. labels Feb 9, 2020
martinthomson
martinthomson reviewed Feb 9, 2020
View reviewed changes
draft-ietf-quic-recovery.md Outdated Show resolved Hide resolved
draft-ietf-quic-recovery.md Outdated Show resolved Hide resolved
janaiyengar
janaiyengar reviewed Feb 28, 2020
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but is there a reason to not require this?

draft-ietf-quic-recovery.md Outdated Show resolved Hide resolved
@ianswett @janaiyengar
Update draft-ietf-quic-recovery.md
36da807 
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
@ianswett
Copy link
Contributor Author

I'm fine with requiring it, given it's already a design issue.

@ianswett ianswett mentioned this pull request Feb 28, 2020
Merged
@ianswett ianswett merged commit 03d4c76 into master Mar 5, 2020
@ianswett ianswett deleted the ianswett-discard-keys-pto branch March 5, 2020 01:20
@marten-seemann marten-seemann mentioned this pull request Mar 5, 2020
Merged
ghedo added a commit to cloudflare/quiche that referenced this pull request Apr 19, 2020
@ghedo
recovery: reset PTO and loss detection timer when discarding keys
c4c3604 
See quicwg/base-drafts#3415.
ghedo added a commit to cloudflare/quiche that referenced this pull request Apr 19, 2020
@ghedo
recovery: reset PTO and loss detection timer when discarding keys
78839c2 
See quicwg/base-drafts#3415.
ghedo added a commit to cloudflare/quiche that referenced this pull request Apr 21, 2020
@ghedo
recovery: reset PTO and loss detection timer when discarding keys
efdd17a 
See quicwg/base-drafts#3415.
ghedo added a commit to cloudflare/quiche that referenced this pull request Apr 22, 2020
@ghedo
recovery: reset PTO and loss detection timer when discarding keys
f5b5fc6 
See quicwg/base-drafts#3415.
ghedo added a commit to cloudflare/quiche that referenced this pull request Apr 22, 2020
@ghedo
recovery: reset PTO and loss detection timer when discarding keys
4e0eeab 
See quicwg/base-drafts#3415.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson left review comments

@janaiyengar janaiyengar janaiyengar approved these changes

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
-recovery -transport design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pto_count should be reset when dropping a packet number space
4 participants
@ianswett @martinthomson @marten-seemann @janaiyengar