Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify that HANDSHAKE_DONE, NEW_TOKEN, PATH_RESPONSE, RCID frames MUST NOT appear in 0-RTT #3431

Closed
wants to merge 1 commit into from
Closed

clarify that HANDSHAKE_DONE, NEW_TOKEN, PATH_RESPONSE, RCID frames MUST NOT appear in 0-RTT #3431

wants to merge 1 commit into from

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented Feb 6, 2020

closes #3430.

marten-seemann
marten-seemann reviewed Feb 6, 2020
View reviewed changes
draft-ietf-quic-tls.md

Note that it is not possible to send the following frames in 0-RTT for various
reasons: ACK, CRYPTO, HANDSHAKE_DONE, NEW_TOKEN, PATH_RESPONSE, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did ACK go?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And CRYPTO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK and CRYPTO are already explicitly called out. See the text above.

@martinthomson
Copy link
Member

The original text was correct. These were not prohibited, they were impossible.

@kazuho
Copy link
Member Author

kazuho commented Feb 6, 2020

@martinthomson If that is the case, I think we need to change table 3 of the transport draft, it currently states HANDSHAKE_DONE can appear only in an 1-RTT packet.

@kazuho
Copy link
Member Author

kazuho commented Feb 6, 2020

Yeah I notice that table 3 marks frames that can only be sent by a server1 as ___1, even though the TLS draft says they are not forbidden in 0-RTT. IMO that's confusing, but I think I can live with status quo.

1: NEW_TOKEN, HANDSHAKE_DONE

@LPardue LPardue added the -tls label Feb 17, 2020
@huitema
Copy link
Contributor

huitema commented Feb 20, 2020

I still think that we have an issue with Retire Connection ID. The current spec allows to send "Retire Connection ID 0" in a 0 RTT packet if the 0-RTT packet is sent to the Initial CID. It is different from CID #0, so that meets the text in 5.1.2 -- but that would cause the handshake to fail. I would like to treat any such RCID as a protocol violation.

@LPardue LPardue added the design An issue that affects the design of the protocol; resolution requires consensus. label Mar 10, 2020
@martinthomson
Copy link
Member

OBE, #3440 is the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann left review comments

Assignees
No one assigned
Labels
-tls design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It is unclear if some frames are forbidden in 0-RTT
5 participants
@kazuho @martinthomson @huitema @marten-seemann @LPardue