Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One of 'host' or ':authority' is required #3475

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Conversation

MikeBishop
Copy link
Contributor

Fixes #3408.

@MikeBishop MikeBishop added design An issue that affects the design of the protocol; resolution requires consensus. -http labels Feb 21, 2020
Copy link
Contributor

@DavidSchinazi DavidSchinazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@royfielding royfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this beg the question "what if the request is for a URI that does not have a mandatory authority component?" All of the other cases are described. I would add something like:

  If the scheme does not have a mandatory authority component and
  none is provided in the request target, the request MUST NOT contain
  the ":authority" pseudo-header and "Host" header fields.

@MikeBishop MikeBishop merged commit 40bde26 into master Mar 23, 2020
@MikeBishop MikeBishop deleted the http/without_authority branch March 23, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is absence of both :authority and Host an error?
5 participants