The packet header changed since this was written #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the version comes before the connection ID fields.
martinthomson
added
editorial
kazuho
reviewed
Mar 12, 2020
draft-ietf-quic-invariants.md
Outdated
| @@ -352,7 +352,7 @@ The following statements are NOT guaranteed to be true for every QUIC version: | |||
| * QUIC uses an AEAD (AEAD_AES_128_GCM {{?RFC5116}}) to protect the packets it | |||
| exchanges during connection establishment | |||
|
|
|||
| * QUIC packet numbers appear after the Version field | |||
| * QUIC packet numbers appear after the connection ID fields | |||
There was a problem hiding this comment.
This statement is bit weird, as the packet number field of an Initial packet does not immediately follow the connection ID fields. The field appears after the token field. And I point this out in relation to Initial packets, because IIUC the primary intended reader here are the middlebox developers, who would have the possibility of analyzing Initial packets, but no other packet types with a packet number field.
There was a problem hiding this comment.
Of course. I was trying to be economical with language, but clearly that needs to be better.
kazuho
approved these changes
Mar 12, 2020
ianswett
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the version comes before the connection ID fields.