Limit connection drops from Version Negotiation #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text was a little too broad. This breaks up the text and adds two caveats to handling rules: 1. If you have handled another packet, then assume that everything is good. 2. If you the VN includes QUIC v1, then assume that something got corrupted. Closes #3532.
martinthomson
added
design
kazuho
approved these changes
Mar 18, 2020
DavidSchinazi
approved these changes
Mar 19, 2020
janaiyengar
reviewed
Mar 19, 2020
draft-ietf-quic-transport.md
Outdated
Comment on lines
1272
to
1276
| A client that supports only this version of QUIC MUST abandon the current | ||
| connection attempt if it receives a Version Negotiation packet. However, a | ||
| client MUST discard any Version Negotiation packet if is has received and | ||
| successfully processed a packet. In addition, a client MUST discard a Version | ||
| Negotiation packet that lists the QUIC version selected by the client. |
There was a problem hiding this comment.
Suggested change
| A client that supports only this version of QUIC MUST abandon the current | |
| connection attempt if it receives a Version Negotiation packet. However, a | |
| client MUST discard any Version Negotiation packet if is has received and | |
| successfully processed a packet. In addition, a client MUST discard a Version | |
| Negotiation packet that lists the QUIC version selected by the client. | |
| A client that supports only this version of QUIC MUST abandon the current | |
| connection attempt if it receives a Version Negotiation packet, with the | |
| following two exceptions. A client MUST discard any Version Negotiation packet | |
| if it has received and successfully processed any other packet, including an | |
| earlier Version Negotiation packet. A client MUST discard a Version Negotiation | |
| packet that lists the QUIC version selected by the client. |
martinthomson
force-pushed
the
ignore-same-version-vn
branch
from
0829f13
to
3694163
Compare
marten-seemann
approved these changes
Mar 19, 2020
ptrd
added a commit
to ptrd/kwik
that referenced
this pull request
Mar 19, 2020
ianswett
approved these changes
Mar 21, 2020
MikeBishop
approved these changes
Mar 25, 2020
janaiyengar
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text was a little too broad. This breaks up the text and adds two
caveats to handling rules:
If you have handled another packet, then assume that everything is good.
If you the VN includes QUIC v1, then assume that something got corrupted.
The issue addresses the second, but I think we were implying the first for some time.
Closes #3532.