Note that state needs to be maintained for each issued CID if the peer chooses to use it #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issued CID if the peer chooses to use it
erickinnear
changed the title
ianswett
approved these changes
Mar 30, 2020
|
This adds a MAY and the issue is already marked design, so I'm inclined to mark this design and do a consensus call on the issue with the next batch. |
|
We could also leave this as |
|
@erickinnear I'd prefer you keep it as is. The process isn't going to cause an appreciable delay in this case. |
martinthomson
approved these changes
Mar 30, 2020
marten-seemann
approved these changes
Mar 31, 2020
kazuho
approved these changes
Mar 31, 2020
MikeBishop
reviewed
Mar 31, 2020
ianswett
added
the
design
Co-Authored-By: Mike Bishop <mbishop@evequefou.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another note when cautioning endpoints about how many CIDs to issue: in this case to note that if you issue a CID you need to be willing for the other endpoint to use 100% of the issued CIDs, which comes with an implicit willingness to maintain state for each path on which that CID could be used. (That's one per path, but # paths == # CIDs in the worst case.)
Fixes #3489.