-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qpack] Add comment explaining static table #3576
Conversation
draft-ietf-quic-qpack.md
Outdated
this methodology, some of the entries may be inconsistent. Notably, | ||
"content-type: text/plain; charset=utf-8" appears twice with two different | ||
whitespace encodings (entries 52 and 54). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this methodology, some of the entries may be inconsistent. Notably, | |
"content-type: text/plain; charset=utf-8" appears twice with two different | |
whitespace encodings (entries 52 and 54). | |
this methodology, some of the entries may be inconsistent. |
It's probably enough to observe that there are inconsistencies that derive from the source data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we've gotten a couple questions about this one in particular, but I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to support @martinthomson because text/plain; charsert=utf-8-
does not appear twice. The other is text/html
.
draft-ietf-quic-qpack.md
Outdated
@@ -1199,6 +1199,12 @@ are registered in the "HTTP/3 Error Code" registry established in {{HTTP3}}. | |||
|
|||
# Static Table | |||
|
|||
This table was generated by analyzing actual internet traffic in 2018 and | |||
manually crafting the table for optimal compression of common headers. Due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "manually crafting" mean? I think that you mean manually removing obvious redundancies and (other stuff we/Mike did).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you want to include some info from #904 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We started from an automated query for data, then:
- Removed vendor-specific artifacts and anti-patterns as best we could
- Sorted the entries into the three tranches described in the comment; the sizes are dictated by the QPACK instruction space, but the selection of which things go in each tranche is a mix of data and judgement.
Fixes #3562