editorial advice for h2<->h3 error propagation #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianswett
approved these changes
Apr 28, 2020
LPardue
added
-http
editorial
MikeBishop
requested changes
Apr 30, 2020
There was a problem hiding this comment.
I think I'd invert the polarity of this, based on what I recall of the list discussion. Error codes largely reflect connection-local issues and mostly shouldn't be propagated. I'm inclined to lead with indicating an upstream failure via the HTTP status codes, then note that there are times it might be useful to proxy a specific stream error, such as REFUSED_STREAM.
MikeBishop
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2817