Don't ACK the ACK #366
Merged
Don't ACK the ACK #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianswett
approved these changes
Mar 7, 2017
draft-ietf-quic-transport.md
Outdated
| after a reasonable number (currently 20) of such packets have been received. | ||
| frames containing the packet number of the received packet. To avoid creating | ||
| an indefinite feedback loop, an endpoint MUST NOT generate an ACK frame in | ||
| response to a packet containing only ACK and PADDING frames. |
There was a problem hiding this comment.
nit: ACK and/or PADDING frames?
janaiyengar
approved these changes
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #291.
Note that #358 contains advice on using PING to elicit an ACK if the endpoint wants to reduce the range of packet numbers that its acknowledgments cover. We can rely on that same advice.
@ianswett, I don't know how you want to manage this and #358. If you want to fold this into #358, that might be best.