Gorrys invariant nits #3730
Merged
Gorrys invariant nits #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an associated issue? |
Closed
Closed
ianswett
added
-invariants
editorial
ianswett
reviewed
Jun 9, 2020
draft-ietf-quic-invariants.md
Outdated
| packet can be delivered to the correct instance of an endpoint. At the | ||
| endpoint, the connection ID is used to identify which QUIC connection the packet | ||
| is intended for. | ||
| connection to be delivered to the wrong transport endpoint. The connection ID |
There was a problem hiding this comment.
What's a transport endpoint? I don't recall us using that term elsewhere, so endpoint seems sufficient to me. Or maybe we need another term for this case?
There was a problem hiding this comment.
This was really trying to avoid having to pull in the definition of "endpoint" from the transport doc. I see that I failed there. Happy to take suggestions, like:
Suggested change
| connection to be delivered to the wrong transport endpoint. The connection ID | |
| connection to be delivered to the wrong destination. The connection ID |
There was a problem hiding this comment.
"destination" sounds like it could be network-layer?
The document uses "QUIC endpoint" elsewhere to refer to an endpoint at the transport layer, so that may perhaps be the term we are looking for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editorial NiTs when reviewing the invariant text. These NiTs address readability issues, and do not intend to change the meaning of the text.