Split minimum idle timeout period #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text as written implied that the actual timeout period was
calculated using:
```
min(max_idle_timeout[client],
max_idle_timeout[server],
3 * PTO)
```
This is silly, as 3PTO is usually smaller than the other two values, and
connections would time out too fast.
Splitting the text regarding the 3PTO backstop makes this clearer.
martinthomson
added
editorial
ekr
reviewed
Jul 8, 2020
draft-ietf-quic-transport.md
Outdated
| @@ -2682,6 +2681,10 @@ ack-eliciting packet if no other ack-eliciting packets have been sent since last | |||
| receiving and processing a packet. Restarting this timer when sending a packet | |||
| ensures that connections are not closed after new activity is initiated. | |||
|
|
|||
| There is no minimum value for max_idle_timeout. To avoid excessively small idle | |||
There was a problem hiding this comment.
This is like a major nitpick, but isn't the minimum value actually 1ms, because 0 means no timeout?
|
Wasn't the intended meaning |
|
I can only speak about my intent, but I did not intend to always add 3PTO to the timeout. The text was clearly more confused than I thought. |
Closed
ianswett
approved these changes
Jul 13, 2020
|
I actually wasn't sure what you meant before, but this is what I assumed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text as written implied that the actual timeout period was
calculated using:
This is silly, as 3PTO is usually smaller than the other two values, and
connections would time out too fast.
Splitting the text regarding the 3PTO backstop makes this clearer.